openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Disapprove

Hi, Ruchir, thank you very much for your work, but there are some problems with your MP:

- You are changing various modules in only one MP. This is only recommended when there are dependencies on the changes between them, because it makes the reviewing process harder.
- There is already another MP that migrates product_costs_incl_bom (https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_cost_incl_bom-yvr/+merge/190348) that conflicts with yours.

So I ask you to separate each of the modules migration in one MP, and for the product_costs_incl_bom module, review the other MP and if you have any improvement on yours, merge with it.

Regards.
-- 
https://code.launchpad.net/~ruchir.shukla/margin-analysis/margin-analysis-migrate-V7/+merge/196278
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.