openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Thanks!

I pushed some change regarding the pep-8 and pep-257 (docstrings). 

On this change:

        'carrier_tracking_ref': fields.char(
            'Carrier Tracking Ref',
            size=32,
            states={'done': [('readonly', True)]}),

I think we shouldn't set the tracking number readonly once the picking is done.
My rationale: if it makes sense for carriers which get the tracking number from the API, one may still want to handle some carrier manually and would still need to edit the field afterwards.

pdf_list is not used, and a semantic detail: not only pdf could be returned (zpl for instance):

        pdf_list = []
        for pick in pickings:
            pdf = pick.generate_single_label()
            pdf_list.append(pdf)


In the access rights files, shouldn't it be stock.group_stock_user and stock.group_stock_manager instead of sales user / manager? 
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr/+merge/196753
Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries.