← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto into lp:account-financial-report

 

> Hi, Humberto, thank you very much for the MP.
> 
> Without checking main functionality, I have seen one problem with multi-line
> texts. These texts results in a totally mess on the interface and on
> translation files, so please change them with some strings with ' or " on
> multiple lines. Python concatenates them automatically, so you don't have to
> put even the + sign (which results in multiple translation strings for one
> sentence, so please avoid it also).
> 
> Let me put an example:
> 
> 'partner_balance': fields.boolean('Partner Balance', help="""Allows to
> Generate a Partner Balance for accounts with moves. Available when
> Balance Sheet and 'Initial | Debit | Credit | YTD' are selected"""),
> 
> can be:
> 
> 'partner_balance': fields.boolean('Partner Balance', help="Allows to"
> "Generate a Partner Balance for accounts with moves. Available when"
> "Balance Sheet and 'Initial | Debit | Credit | YTD' are selected"),
> 
> Regards.

Thank you very much for your input Pedro,

In order to make account_financial_report code better complaint to PEP8
I have run the autopep8 command on the whole module in addition to the
changes that you have already suggested.

Could please give me your feedback again.

Best Regards.
-- 
https://code.launchpad.net/~vauxoo/account-financial-report/7.0-afr_GB_partner-dev-hbto/+merge/196764
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.


References