openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing

Hi, Joël, thanks for the contribution. Can you please check:

- l.74: You forget the ')' at the end.
- l.98: 'products' is not a list?
- l.173, l.177: Can you use DATETIME variable?

And now a little off-topic: I'm seeing some MPs for your part with history properties. Don't you think that is interesting to develop a new field type that handle this in a standard way (the same method as for example properties, that store data in a foreign table) and propose its inclusion in core / OCB?

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-pending-merge/+merge/196921
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.