openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

I would like to see a multicompany test case for this as using raw SQL always has a chance of bypassing security (or a comment in the code explaining why it does not bypass multicompany rules)

add space after ':' in litteral dictionaries

I'm concerned about the use of "==" to compare floats in the tests, since this can lead to assertion failures due to the binary representation of floats. 
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-bugfix-1189480-with-perf-mdh/+merge/197162
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.