openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hello thanks for the fix

I would just suggest a little change to do the same as we did in

https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-fix-lastnameempty/+merge/167906


Something like:

names = (record.lastname, record.firstname)
fullname = " ".join([s for s in names if s])

That might be a bit more pythonic

Regards
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management.