← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

 

Sandy,
thanks for your review.

1. I think that case falls under the "Aligned with opening delimiter" rule, which should be fine. The pep8 tool indeed likes it.

2. fixed.

3. I think this is 7.0 style, while all but one of the 6.1 standard modules do "from osv".

Best
-- 
https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep/+merge/197474
Your team Manufacture Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1.


References