← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl

 

Review: Needs Fixing code review

__init__.py:
* vim comment should be the last line

__openerp__.py:
* pep8 issues: l.55,56,57,61,62,63,64,65,66,68,69 whitespace before colon

invoice.py:
* pep8: l.196 should be two lines before class

invoice_view.xml:
you might want to remove your commented out code

i18n/fr.po:
l.127 in french you don't capitalize every noun in a title like you do in English: Ligne de facturation

i18n/{fr,en}.po:
entries don't match invoice_sequence.pot
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe/+merge/197175
Your team Sale Core Editors is requested to review the proposed merge of lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl.


References