openerp-community-reviewer team mailing list archive

[camptocamp-business-robot <business-robots@xxxxxxxxxxxxxx>]

Review: Needs Fixing no test, code review

Please use:
from openerp.osv import orm, fields

and instanciate the classes with:
class x_y_z(orm.Model):
class a_b_c(orm.TransientModel):

The other form is deprecated.

In osv.py:
"
# deprecated - for backward compatibility.
osv = Model
osv_memory = TransientModel
osv_abstract = AbstractModel # ;-)
"

I'm not found of the extends fields_view_get approach but in this case it is probably less code to maintain than redefining views or doing a function field to be used by attrs so it is OK for me.

Opinion:
Adding sub function in open_lot will make it more readable and easier to override.


-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows.