openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:kmsistemas-openerp-addons into lp:ocb-addons/6.1

To: Jordi Llinares - KM Sistemas <jordi@xxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Mon, 09 Dec 2013 16:09:52 -0000
In-reply-to: <20131202121426.16996.98245.launchpad@ackee.canonical.com>
Reply-to: mp+197352@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

Hi, Jordi, thank you very much for the MP!

I wonder why all the fields definition lines are overwritten on your proposal. As OCB pretends to deviate the minimum from official branches, please stay what is not incorrect as is, and only change the minimum to fix the problem.

Can you please restore the code then and ask for another MP?

Thank you.

Regards.
-- 
https://code.launchpad.net/~jorgellinares/ocb-addons/6.1/+merge/197352
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.

References

[Merge] lp:kmsistemas-openerp-addons into lp:ocb-addons/6.1
From: Jordi Llinares - KM Sistemas, 2013-12-02