openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Pedro,

I know you do a lot of good work, but I am a little unhappy with a proposal that you did not even fully test yourself (thank you for your honesty though!). That's enough to warrant a disapproval as far as I'm concerned, as you can't really expect a reviewer to spend valuable time on that.

Also, I am having a hard time trying to find out what this change really does. There is no bug report, and it even looks like there are several changes. In that case, you really should put in a detailed description of what each change does, if only to convince the reviewers that these changes are a good thing. And if upstream revision numbers are the only pointers, at least make them links to the revisions on Launchpad!





-- 
https://code.launchpad.net/~pedro.baeza/ocb-addons/6.1-fix-1223243/+merge/198291
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.