openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis

To: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
From: Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>
Date: Tue, 10 Dec 2013 15:08:20 -0000
In-reply-to: <20131204104843.17559.23127.codereview@chaenomeles.canonical.com>
Reply-to: mp+197684@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve no test, code review

Hello,

I have just committed minor PEP8 fixes.
Code LGTM but I'm not sure on functional part of product_cost_incl_costs_with_bom.
I'm not confident on the way cost are computed.

Regards

Nicolas


-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge/+merge/197684
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.

References

Re: lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis
From: Joël Grand-Guillaume, 2013-12-04