openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

> __openerp__: pep8 issues
>  * spaces before the colon on l.56,57,58,59,66,67,68,71

Fixed, thanks. 


> picking_priority.py:
>  * l.123 you're not checking if ids is an int or a list, this could lead to a
> problem with search and an error on l.137

I respectfully disagree. The name of the parameter implies that expected type is a list. Adding such tests only clutters the code imo. Calling the function with a single integer would be a bug in the calling function. 
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe/+merge/197206
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe into lp:stock-logistic-flows/7.0.