openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

product_cost_incl_bom/product_cost_incl_bom.py|45 col 1| F821 undefined name 'toposort2'
-> Rename the function name in comment as in its signature

product_cost_incl_bom/product_cost_incl_bom.py|255 col 1| F841 local variable 'res' is assigned to but never used



product_cost_incl_bom_price_history/product.py|26 col 1| F401 'SUPERUSER_ID' imported but unused

product_cost_incl_bom_price_history/product.py|33 col 80| E501 line too long (103 > 79 characters)
-> Can't we append using a relative path or do an import first ?


product_price_history/wizard/historic_prices.py|41 col 1| F841 local variable 'e' is assigned to but never used
product_price_history/wizard/historic_prices.py|64 col 20| E711 comparison to None should be 'if cond is None:'

Better to write

if variable is None:

instead of variable == None

product_price_history/wizard/historic_prices.py|130 col 1| F841 local variable 'user_obj' is assigned to but never used


action_open_wingow in product_price_history/wizard/historic_prices.py
Could be rewriten with using a browse record of wizard instead of a read and having to get the fields


product_stock_cost_field_report/report_stock_move.py|22 col 1| F401 'fields' imported but unused

-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-cost-price-store-improv-jge/+merge/198551
Your team Margin Analysis Core Editors is requested to review the proposed merge of lp:~camptocamp/margin-analysis/7.0-cost-price-store-improv-jge into lp:margin-analysis.