openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #02181
Re: [Merge] lp:~jean-lelievre/purchase-report/product_stock_type into lp:purchase-report
Review: Needs Fixing code review
Could you take the time to bring this to the 7.0 community addons coding conventions. This includes:
* not using the shortcut imports (things in the openerp namespace need to be imported from openerp)
* using the from . import xxx for relative imports (typically in __init__.py files)
* using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory
* not instanciating the model classes
* following PEP8 for spacing, line wrapping, etc.
Thanks
--
https://code.launchpad.net/~jean-lelievre/purchase-report/product_stock_type/+merge/182050
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.