openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Thanks Yannick.

The docstring ":return: list of {tracking_id, file, file_type}" is confusing. What does it return? (it let me think of a set in the Python 2.7+ syntax: {1, 2}. Isn't it a tuple?

I think that tracking_id should not be mandatory, when we don't use the packs and only have a label per picking.
If you agree with that, 'tracking_id' returned by generate_pack_labels() could be False and the docstring should explain that. Also, I propose to rename generate_pack_labels() to generate_labels() as it can generate labels for packs or just the picking.

-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr/+merge/196753
Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries.