← Back to team overview

openerp-community-reviewer team mailing list archive

lp:~camptocamp/account-financial-report/7.0-company-opening-period-mdh into lp:account-financial-report

 

Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/account-financial-report/7.0-company-opening-period-mdh into lp:account-financial-report.

Commit message:
Added "same company" check on opening period search

Requested reviews:
  Account Report Core Editors (account-report-core-editor)

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-company-opening-period-mdh/+merge/199316

If you have multiple companies, and as such, multiple opening periods, you only retrieve one regardless of company code; I extended the search's domain in order to account for this.
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-company-opening-period-mdh/+merge/199316
Your team Account Report Core Editors is requested to review the proposed merge of lp:~camptocamp/account-financial-report/7.0-company-opening-period-mdh into lp:account-financial-report.
=== modified file 'account_financial_report_webkit/report/common_reports.py'
--- account_financial_report_webkit/report/common_reports.py	2013-09-12 20:53:27 +0000
+++ account_financial_report_webkit/report/common_reports.py	2013-12-17 16:22:16 +0000
@@ -226,7 +226,8 @@
         return period_obj.search(self.cursor, self.uid,
                                  [('special', '=', True),
                                   ('date_start', '>=', period.date_start),
-                                  ('date_stop', '<=', period.date_stop)],
+                                  ('date_stop', '<=', period.date_stop),
+                                  ('company_id', '=', period.company_id.id)],
                                   limit=1)
 
     def periods_contains_move_lines(self, period_ids):


Follow ups