openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr into lp:report-print-send

To: mp+194710@xxxxxxxxxxxxxxxxxx
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Fri, 20 Dec 2013 14:04:36 -0000
In-reply-to: <20131111155036.4756.53085.launchpad@ackee.canonical.com>
Reply-to: mp+194710@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hi,


Thanks for this proposal. Just a little remarks:

 * Line 923, 1079, 1484 : Use explicit Kwargs context=context or ctx

Otherwise, LGTM.

Regards,

-- 
https://code.launchpad.net/~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr/+merge/194710
Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send.

References

lp:~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr into lp:report-print-send
From: Yannick Vaucher @ Camptocamp, 2013-11-11