openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hello Nishant,

Thanks for the changes.

Here I just ran pyflakes8 and here some things to fixe to respect PEP8 standards

Please remove unused import and variables:

wizard/base_synchro.py|23 col 1| F401 'date' imported but unused
wizard/base_synchro.py|27 col 1| F401 're' imported but unused
wizard/base_synchro.py|28 col 1| F401 'tools' imported but unused
wizard/base_synchro.py|30 col 1| F401 'unicodedata' imported but unused
wizard/base_synchro.py|179 col 1| F841 local variable 'pool' is assigned to but never used
wizard/base_synchro.py|152 col 1| F841 local variable 'synid' is assigned to but never used


And for PEP8 nitpickings:
- Use 2 blank lines between classes
- Use 1 blank line between methods
- Remove whitespace in blank lines
- Remove trailing white space
- Try to respect maximum of 80 characters
- add a whitespace after ':'

For details please use pyflakes8 and/or refer to PEP8 standards

Cheers
-- 
https://code.launchpad.net/~serpentcs/server-env-tools/7.0-base_synchro/+merge/183102
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.