openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hello Alexis,

Can you add translation pot files?

l.1745 can you split your tiny comment ?
With it I can't have twice your code aside on a single screen (not a so tiny one) in my vim =)

And other lines that are a bit too long
account_cutoff_prepaid/account.py|53 col 80| E501 line too long (252 > 79 characters)

account_cutoff_prepaid/product.py|33 col 80| E501 line too long (148 > 79 characters)
account_cutoff_prepaid/account.py|51 col 80| E501 line too long (119 > 79 characters)
account_cutoff_prepaid/account.py|89 col 80| E501 line too long (101 > 79 characters)
account_cutoff_prepaid/account.py|131 col 80| E501 line too long (155 > 79 characters)
account_cutoff_base/account_cutoff.py|307 col 80| E501 line too long (172 > 79 characters)
account_cutoff_base/account_cutoff.py|230 col 80| E501 line too long (144 > 79 characters)
account_cutoff_base/account_cutoff.py|232 col 80| E501 line too long (123 > 79 characters)
account_cutoff_base/account_cutoff.py|239 col 80| E501 line too long (117 > 79 characters)
account_cutoff_base/account_cutoff.py|242 col 80| E501 line too long (116 > 79 characters)
account_cutoff_base/account_cutoff.py|245 col 80| E501 line too long (109 > 79 characters)
account_cutoff_base/account_cutoff.py|246 col 80| E501 line too long (133 > 79 characters)
account_cutoff_base/account_cutoff.py|248 col 80| E501 line too long (132 > 79 characters)
account_cutoff_base/account_cutoff.py|80 col 80| E501 line too long (159 > 79 characters)
account_cutoff_base/account_cutoff.py|105 col 80| E501 line too long (136 > 79 characters)

And space after coma is required in PEP8 can you add it in your domains


-- 
https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992
Your team Account Core Editors is subscribed to branch lp:account-closing.