openerp-community-reviewer team mailing list archive

[Raphaël Valyi - http://www.akretion.com <rvalyi@xxxxxxxxx>]

Raphaël Valyi - http://www.akretion.com has proposed merging lp:~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing into lp:openerp-fiscal-rules.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing/+merge/200040

[FIX] removed on_change formatting in XML views as it would make the yaml import parser fail to parse the on_change definitions
-- 
https://code.launchpad.net/~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing/+merge/200040
Your team Account Core Editors is requested to review the proposed merge of lp:~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing into lp:openerp-fiscal-rules.

=== modified file 'account_fiscal_position_rule_sale/sale_view.xml'
--- account_fiscal_position_rule_sale/sale_view.xml	2013-02-11 13:36:48 +0000
+++ account_fiscal_position_rule_sale/sale_view.xml	2013-12-25 19:17:37 +0000
@@ -9,27 +9,17 @@
                <field name="priority">26</field>
                <field name="arch" type="xml">
                 <field name="shop_id" position="attributes">
-                    <attribute name="on_change">
-                        onchange_shop_id(shop_id, context, partner_id, partner_invoice_id, partner_shipping_id)
-                    </attribute>
+                    <attribute name="on_change">onchange_shop_id(shop_id, context, partner_id, partner_invoice_id, partner_shipping_id)</attribute>
                 </field>
                 <field name="partner_invoice_id" position="attributes">
-                    <attribute name="on_change">
-                        onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)
-                    </attribute>
+                    <attribute name="on_change">onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)</attribute>
                 </field>
                 <field name="partner_shipping_id" position="attributes">
-                    <attribute name="on_change">
-                        onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)
-                    </attribute>
+                    <attribute name="on_change">onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)</attribute>
                 </field>
                 <field name="partner_id" position="attributes">
-                    <attribute name="on_change">
-                        onchange_partner_id(partner_id, context)
-                    </attribute>
-                    <attribute name="context">
-                        {'shop_id': shop_id}
-                    </attribute>
+                    <attribute name="on_change">onchange_partner_id(partner_id, context)</attribute>
+                    <attribute name="context">{'shop_id': shop_id}</attribute>
                 </field>
             </field>
         </record>