← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

 

Review: Needs Fixing code review

Alejandro, please fix these things:

- Remove all the chart template stuff, that doesn't belong to this module.
- Change module name and description in manifest file accordingly.
- Restart the version numbering to 1.0.
- Remove comment about templates at the beginning in account.py.
- Change the icon to one that is not duplicated from standard ones. You can make a slightly variation, for example.
- Remove 'l10n_es' as dependency and add 'account'.
- Remove template views modifications.
- Rebuild translations.

Thank you very much.

Regards.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.


Follow ups

References