openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

PEP8:
purchase_landed_costs/__init__.py:3:2: W291 trailing whitespace
purchase_landed_costs/__init__.py:19:75: W291 trailing whitespace

purchase_landed_costs/__openerp__.py:30:40: W291 trailing whitespace
purchase_landed_costs/__openerp__.py:42:27: E202 whitespace before ']'

purchase_landed_costs/product.py:19:13: E128 continuation line under-indented for visual indent
purchase_landed_costs/product.py:31:13: E128 continuation line under-indented for visual indent

purchase_landed_costs/purchase.py: 37 PEP8 errors
purchase_landed_costs/stock.py: 25 PEP8 errors

Code:
purchase_landed_costs/purchase.py 62:9: you have the same two lines twice
purchase_landed_costs/purchase.py 82:9: you have the same two lines twice
purchase_landed_costs/purchase.py 280:57: should be context=context
purchase_landed_costs/purchase.py 294:57: should be context=context

purchase_landed_costs/stock.py:20:21: missing context=context
purchase_landed_costs/stock.py:38:21: missing context=context
purchase_landed_costs/stock.py:40:15: distrubution -> distribution
purchase_landed_costs/stock.py:62:21: missing context=context
purchase_landed_costs/stock.py:73:21: missing context=context
purchase_landed_costs/stock.py:113:21: missing context=context
purchase_landed_costs/stock.py:128:21: missing context=context
purchase_landed_costs/stock.py 143:18: costss -> costs
purchase_landed_costs/stock.py:144:21: missing context=context
purchase_landed_costs/stock.py:159:21: missing context=context
purchase_landed_costs/stock.py:173:21: missing context=context
purchase_landed_costs/stock.py:188:21: missing context=context

-- 
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl/6.1.