openerp-community-reviewer team mailing list archive

[Daniel Reis <dgreis@xxxxxxx>]

> project_sla/project_sla_demo.xml:104:17: Xml Tag Has Empty Body
> project_sla/project_sla_demo.xml:127:17: Xml Tag Has Empty Body

I can see that it could be neater, but strictly speaking this neither a programming nor a style issue, so I think it isn't worth the trouble.


> As for translating _description, if it's not done here (_description =
> _('...')), then it won't be translated in python code (ex: mail_thread widget
> --  though that one has a soon-to-be-fixed bug too https://bugs.launchpad.net
> /openobject-addons/+bug/1262000).

I can't find a similar example in the official addons; it seems to me that it's a temporary workaround for a bug. I would prefer to not use it unless proven to be absolutely necessary.

-- 
https://code.launchpad.net/~dreis-pt/contract-management/7.0-project_sla-dr/+merge/199645
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.