openerp-community-reviewer team mailing list archive

["Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Please fix your PEP8 issues:

$ flake8 base_partner_merge/ --ignore=E501,F401
base_partner_merge/base_partner_merge.py:47:1: F812 list comprehension redefines 'email' from line 39
base_partner_merge/base_partner_merge.py:66:1: E302 expected 2 blank lines, found 1
base_partner_merge/base_partner_merge.py:266:9: E301 expected 1 blank line, found 0
base_partner_merge/base_partner_merge.py:322:46: E228 missing whitespace around modulo operator
base_partner_merge/base_partner_merge.py:451:29: E128 continuation line under-indented for visual indent
base_partner_merge/base_partner_merge.py:452:33: E128 continuation line under-indented for visual indent
base_partner_merge/base_partner_merge.py:738:46: W291 trailing whitespace
base_partner_merge/base_partner_merge.py:739:55: W291 trailing whitespace
base_partner_merge/validate_email.py:29:5: E301 expected 1 blank line, found 0
base_partner_merge/validate_email.py:29:33: E701 multiple statements on one line (colon)
base_partner_merge/validate_email.py:48:13: E126 continuation line over-indented for hanging indent
base_partner_merge/validate_email.py:50:17: E126 continuation line over-indented for hanging indent
base_partner_merge/validate_email.py:52:22: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:55:21: E126 continuation line over-indented for hanging indent
base_partner_merge/validate_email.py:57:14: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:61:53: E261 at least two spaces before inline comment
base_partner_merge/validate_email.py:63:17: E126 continuation line over-indented for hanging indent
base_partner_merge/validate_email.py:65:22: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:67:33: E126 continuation line over-indented for hanging indent
base_partner_merge/validate_email.py:70:26: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:73:22: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:75:34: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:78:18: E121 continuation line indentation is not a multiple of four
base_partner_merge/validate_email.py:84:1: E302 expected 2 blank lines, found 1
base_partner_merge/validate_email.py:84:41: E231 missing whitespace after ','
base_partner_merge/validate_email.py:97:23: E701 multiple statements on one line (colon)
base_partner_merge/validate_email.py:99:45: E226 missing whitespace around arithmetic operator
base_partner_merge/validate_email.py:105:34: E701 multiple statements on one line (colon)
base_partner_merge/validate_email.py:107:37: E701 multiple statements on one line (colon)
base_partner_merge/validate_email.py:110:37: E701 multiple statements on one line (colon)
base_partner_merge/validate_email.py:112:55: E261 at least two spaces before inline comment
base_partner_merge/validate_email.py:112:56: E262 inline comment should start with '# '
base_partner_merge/validate_email.py:116:42: W291 trailing whitespace
base_partner_merge/wizard/portal_wizard.py:25:1: E302 expected 2 blank lines, found 1
base_partner_merge/wizard/portal_wizard.py:32:57: E128 continuation line under-indented for visual indent
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.