← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~serpentcs/sale-reports/sale-serpentcs into lp:sale-reports

To: mp+190321@xxxxxxxxxxxxxxxxxx
From: "Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 27 Dec 2013 19:15:50 -0000
In-reply-to: <20131010095048.21708.88383.launchpad@ackee.canonical.com>
Reply-to: mp+190321@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

Hello Nishant,

Can you use local import (from . import ...) in your __init__.py files ?

I am not familiar with webkit report. Don't they need a translation file ?

Thanks.
-- 
https://code.launchpad.net/~serpentcs/sale-reports/sale-serpentcs/+merge/190321
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports.

References

[Merge] lp:~serpentcs/sale-reports/sale-serpentcs into lp:sale-reports
From: Nishant Jogi, 2013-10-10