openerp-community-reviewer team mailing list archive

["Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Hello Nishant,

Please make sure your code respects the community guidelines:
https://doc.openerp.com/contribute/05_developing_modules/#community-guidelines

l114,115,l650,651,652,l1227,1228,1229: can you use local import (from . import ...)

$ flake8 base_headers_webkit --ignore=E501,F401
base_headers_webkit/__init__.py:29:1: W391 blank line at end of file
base_headers_webkit/__openerp__.py:34:24: W291 trailing whitespace
base_headers_webkit/__openerp__.py:37:3: E127 continuation line over-indented for visual indent
base_headers_webkit/__openerp__.py:46:1: E124 closing bracket does not match visual indentation

$ flake8 hr_attendance_webkit --ignore=E501,F401
hr_attendance_webkit/__init__.py:23:66: W292 no newline at end of file
hr_attendance_webkit/__openerp__.py:23:11: E203 whitespace before ':'
hr_attendance_webkit/__openerp__.py:24:14: E203 whitespace before ':'
hr_attendance_webkit/__openerp__.py:25:13: E203 whitespace before ':'
hr_attendance_webkit/__openerp__.py:26:15: E203 whitespace before ':'
hr_attendance_webkit/__openerp__.py:27:18: E203 whitespace before ':'
hr_attendance_webkit/__openerp__.py:33:14: E203 whitespace before ':'
hr_attendance_webkit/report/attendance_by_month.py:32:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/report/attendance_by_month.py:37:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/report/attendance_by_month.py:43:26: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:44:29: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:45:27: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:46:27: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:47:26: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:52:22: W291 trailing whitespace
hr_attendance_webkit/report/attendance_by_month.py:53:15: E271 multiple spaces after keyword
hr_attendance_webkit/report/attendance_by_month.py:55:31: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:56:1: W293 blank line contains whitespace
hr_attendance_webkit/report/attendance_by_month.py:62:1: F841 local variable 'days' is assigned to but never used
hr_attendance_webkit/report/attendance_by_month.py:62:15: E225 missing whitespace around operator
hr_attendance_webkit/report/attendance_by_month.py:63:53: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:63:59: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:78:1: W293 blank line contains whitespace
hr_attendance_webkit/report/attendance_by_month.py:79:25: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:79:31: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:83:38: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:89:24: E225 missing whitespace around operator
hr_attendance_webkit/report/attendance_by_month.py:90:24: E225 missing whitespace around operator
hr_attendance_webkit/report/attendance_by_month.py:107:101: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:109:98: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_by_month.py:117:61: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/attendance_by_month.py:117:64: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/attendance_by_month.py:124:31: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_by_month.py:129:1: W391 blank line at end of file
hr_attendance_webkit/report/attendance_errors.py:28:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/report/attendance_errors.py:36:28: E231 missing whitespace after ':'
hr_attendance_webkit/report/attendance_errors.py:44:5: E303 too many blank lines (2)
hr_attendance_webkit/report/attendance_errors.py:53:31: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/attendance_errors.py:63:24: E231 missing whitespace after ','
hr_attendance_webkit/report/attendance_errors.py:64:44: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:64:46: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:64:57: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:64:59: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:64:68: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:64:70: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:43: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:45: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:56: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:58: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:67: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:65:69: E251 unexpected spaces around keyword / parameter equals
hr_attendance_webkit/report/attendance_errors.py:70:45: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/attendance_errors.py:74:17: E126 continuation line over-indented for hanging indent
hr_attendance_webkit/report/attendance_errors.py:75:33: E272 multiple spaces before keyword
hr_attendance_webkit/report/attendance_errors.py:76:17: E126 continuation line over-indented for hanging indent
hr_attendance_webkit/report/attendance_errors.py:82:1: W391 blank line at end of file
hr_attendance_webkit/report/timesheet.py:32:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/report/timesheet.py:35:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/report/timesheet.py:42:23: E231 missing whitespace after ':'
hr_attendance_webkit/report/timesheet.py:43:23: E231 missing whitespace after ':'
hr_attendance_webkit/report/timesheet.py:44:29: E231 missing whitespace after ':'
hr_attendance_webkit/report/timesheet.py:45:27: E231 missing whitespace after ':'
hr_attendance_webkit/report/timesheet.py:53:25: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:53:31: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:56:1: W293 blank line contains whitespace
hr_attendance_webkit/report/timesheet.py:59:18: E225 missing whitespace around operator
hr_attendance_webkit/report/timesheet.py:59:21: W291 trailing whitespace
hr_attendance_webkit/report/timesheet.py:61:63: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:64:22: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:64:28: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:70:1: W293 blank line contains whitespace
hr_attendance_webkit/report/timesheet.py:71:19: E225 missing whitespace around operator
hr_attendance_webkit/report/timesheet.py:72:20: E225 missing whitespace around operator
hr_attendance_webkit/report/timesheet.py:76:70: W291 trailing whitespace
hr_attendance_webkit/report/timesheet.py:82:1: W293 blank line contains whitespace
hr_attendance_webkit/report/timesheet.py:83:45: E231 missing whitespace after ','
hr_attendance_webkit/report/timesheet.py:84:27: W291 trailing whitespace
hr_attendance_webkit/report/timesheet.py:86:1: W293 blank line contains whitespace
hr_attendance_webkit/report/timesheet.py:90:1: F841 local variable 'emp' is assigned to but never used
hr_attendance_webkit/report/timesheet.py:99:107: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/timesheet.py:113:122: E226 missing whitespace around arithmetic operator
hr_attendance_webkit/report/timesheet.py:116:23: W291 trailing whitespace
hr_attendance_webkit/report/timesheet.py:117:1: W293 blank line contains whitespace
hr_attendance_webkit/wizard/hr_attendance_bymonth.py:25:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/wizard/hr_attendance_bymonth.py:27:5: E301 expected 1 blank line, found 0
hr_attendance_webkit/wizard/hr_attendance_bymonth.py:29:14: E121 continuation line indentation is not a multiple of four
hr_attendance_webkit/wizard/hr_attendance_byweek.py:27:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/wizard/hr_attendance_byweek.py:32:14: E121 continuation line indentation is not a multiple of four
hr_attendance_webkit/wizard/hr_attendance_error.py:26:1: E302 expected 2 blank lines, found 1
hr_attendance_webkit/wizard/hr_attendance_error.py:35:175: E203 whitespace before ','
hr_attendance_webkit/wizard/hr_attendance_error.py:35:176: E231 missing whitespace after ','
hr_attendance_webkit/wizard/hr_attendance_error.py:35:244: E231 missing whitespace after ','
hr_attendance_webkit/wizard/hr_attendance_error.py:46:14: E121 continuation line indentation is not a multiple of four
-- 
https://code.launchpad.net/~serpentcs/webkit-utils/utils-serpentcs/+merge/190327
Your team Webkit Utils Core Editors is subscribed to branch lp:webkit-utils.