openerp-community-reviewer team mailing list archive

["Ronald Portier \(Therp\)" <ronald@xxxxxxxx>]

Review: Needs Fixing

Dear Etienne,

I do not think it is a good idea to have one merge proposal for two changes that are nearly totally unrelated. Except for the fact that they modify the same file. Please put the change of the address selection in a separate proposal.

As for the ordering problem, I think your proposal is quite risky. If you really want to be sure that date is always filled with a valid value - based on date_expected until a move is done -, I feel it would be more appropiate to override create/write methods. Otherwise you might still end up sorting on an date withouth value.
-- 
https://code.launchpad.net/~hirt/ocb-addons/6.1_stock_use_date_always/+merge/194646
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.