openerp-community-reviewer team mailing list archive

[Graeme Gellatly <gdgellatly@xxxxxxxxx>]

My only comment is that is there any reason to include the imports in the mako template function.  Can they not just be declared normally.

But otherwise I can confirm that this module does not work without this patch on recent source.  From memory you get an undeclared char ! traceback.  I have not yet tested this patch if it resolves the issue, but would seem to point to it.

Will test fully tomorrow.
-- 
https://code.launchpad.net/~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako/+merge/200014
Your team Account Report Core Editors is requested to review the proposed merge of lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report.