openerp-community-reviewer team mailing list archive

["Ronald Portier \(Therp\)" <ronald@xxxxxxxx>]

Review: Abstain

Alexis,

Very well that when a user changes the fiscal position, there is the possibility to adapt the taxes and accounts.

Just wondering why the user should need to press a button. Should this not be an onchange action on the fiscal position?

As for the code itself it mostly seems good to me. Just two remarks:

1. Maybe better to avoid the line continuation with \ at #129 and #133 by using ( and )

2. The extremely long lines in the xml at #168 and #185 might be avoided by having each attribute on its own line.

So for the moment I abstain on this proposal.
-- 
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
Your team Account Core Editors is subscribed to branch lp:account-invoicing.