openerp-community-reviewer team mailing list archive

["Ronald Portier \(Therp\)" <ronald@xxxxxxxx>]

Review: Approve code review and test

Hello,

Good to know a function like resolve_2many_commands exists. By the way I could only find one place where it is used in the official addons, that is in account/account_move_line.py.

I tested the module and found it to work perfectly.

I checked:
- entering an invoice with a line, saving it and then changing the fiscal position
- change it back again
- add another invoice line, NOT save it and change the fiscal position
- then save it and change it back again
- and then some variations with and withouth pressing update on taxes in between.
- add an invoice line withouth a product. Changed the fiscal position. Got the warning that was expected.

Code also looks very nice.



-- 
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
Your team Account Core Editors is subscribed to branch lp:account-invoicing.