openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

You've changed the name of the key in project_billing_utils/analytic.py as I suggested yesterday evening, but forgot to change it in project_billing_utils/wizard/dissociate_aal.py (line 127 of the diff below), which means  the branch in the current state no longer fixes lp:1266850 

Stylistically I'm not fond of the blank line between class definition line and docstring, or the blank line at the end of the docstring (but I won't fight over this). 
-- 
https://code.launchpad.net/~camptocamp/project-reporting/7.0-fix-dissociate-lep/+merge/200695
Your team Project Core Editors is subscribed to branch lp:project-reporting.