← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr into lp:openerp-reporting-engines

 

Thanks that's a nice module.

Besides the changes requested above, I would just propose to replace the french translation "Companie" (misspelled BTW) by "Société" as this word is used usually.

Can you rename the argument "cursor" to "cr" where it occurs?

l.283,293: needs """ for docstring
-- 
https://code.launchpad.net/~camptocamp/openerp-reporting-engines/7.0-add-base_report_assembler-yvr/+merge/194304
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-reporting-engines.


References