← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

 

Review: Needs Fixing code review, no tests

l95 and l98 you can use relative xpath expr like

<xpath expr="//field[@name='move_created_ids']/tree/button[@string='Scrap Products']" position="after">

That way adding a html level or moving the field won't affect your changes.

Otherwise looks good to me.
-- 
https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544
Your team Manufacture Core Editors is subscribed to branch lp:openerp-manufacturing/6.1.


References