openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

To: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Tue, 14 Jan 2014 16:41:07 -0000
In-reply-to: <20140106145824.10609.64853.launchpad@ackee.canonical.com>
Reply-to: mp+200544@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Thanks for the changes.

Sorry, it seems I missed those in python code the first time:

l138 could you use orm.Model instead of osv.osv

l174 missing context propagation
-- 
https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544
Your team Manufacture Core Editors is subscribed to branch lp:openerp-manufacturing/6.1.

References

lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1
From: Leonardo Pistone @ camptocamp, 2014-01-06