openerp-community-reviewer team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hi,

Thanks for the contribs ! A few remarks of mine:

 * In import, use full path : from . import blabla (line 28, 29, 399)
 * In __openerp__.py: 
   * please update the tag (update_xml, init_xml, ... are obsolete) use "data" instead
   * In the description, I will very much appreciate you explain here why to use this module , why it has been made so the user can understand what it bring compared to standard OpenERP
 * Add a i18n folder and the .pot file for translation

Otherwise LGTM, thanks for providing tests with it !
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-add-account_move_batch_validate-lep/+merge/201187
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.