openerp-community-reviewer team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Disapprove code review, no tests

Hi,


My opinion here that this fix is dangerous. The name of the method that use it is "_authorized_reconcile", which means, we check reconcile stuff not state stuff... The problem comes from another place.

May be you should use the "flag" : if not context.get('from_parent_object', False):

Add from_parent_object in context in the wizard that generate the end of year entries and you should not face this trouble anymore.

But please, do not allow state change, this is why we introduce the constraints ;)

Thanks,

Joël
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/account-contraints-state-vre/+merge/193884
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.