openerp-community-reviewer team mailing list archive

["elhadji.dem@xxxxxxxxxxxxxxxxxxxx" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>]

elhadji.dem@xxxxxxxxxxxxxxxxxxxx has proposed merging lp:~eh-dem/partner-contact-management/remove_is_company into lp:partner-contact-management.

Requested reviews:
  Partner and Contact Core Editors (partner-contact-core-editors)

For more details, see:
https://code.launchpad.net/~eh-dem/partner-contact-management/remove_is_company/+merge/202543

remove is_company from contact view added in https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit/+merge/195092.
In partner view, we create a company; from the company, we create a contact and again you add is_company field; it is redundant and the view doesn't display well

-- 
https://code.launchpad.net/~eh-dem/partner-contact-management/remove_is_company/+merge/202543
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~eh-dem/partner-contact-management/remove_is_company into lp:partner-contact-management.

=== modified file 'partner_firstname/partner_view.xml'
--- partner_firstname/partner_view.xml	2013-11-13 16:18:13 +0000
+++ partner_firstname/partner_view.xml	2014-01-21 19:54:46 +0000
@@ -38,11 +38,6 @@
             <field name="firstname"/>
            </group> 
         </xpath>
-        <xpath expr="//form[@string='Contact']/sheet/div/h1" position="after">
-           <field name="is_company" on_change="onchange_type(is_company)" class="oe_inline"/>
-           <label for="is_company" string="Is a Company?"/>)
-        </xpath>
-
 
       </field>
     </record>