openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~nemry/partner-contact-management/7.0-partner-firstname into lp:partner-contact-management

To: "Jonathan Nemry \(Acsone\)" <jonathan.nemry@xxxxxxxxx>
From: "Olivier Laurent \(Acsone\)" <olivier.laurent@xxxxxxxxx>
Date: Wed, 22 Jan 2014 08:23:19 -0000
In-reply-to: <20140121161926.13720.46828.launchpad@ackee.canonical.com>
Reply-to: mp+202494@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

For the _write_name method, it would be better to check for the firstname with an expression like "name.endswith(space+firstname)"... because maybe more than one space exists in the name
-- 
https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202494
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.

References

[Merge] lp:~nemry/partner-contact-management/7.0-partner-firstname into lp:partner-contact-management
From: Jonathan Nemry (Acsone), 2014-01-21