openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

To: "Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>
From: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
Date: Fri, 24 Jan 2014 10:56:15 -0000
In-reply-to: <20140116125926.27658.77347.launchpad@ackee.canonical.com>
Reply-to: mp+201920@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

Vincent,

If I get it correctly, you use credit_control_line_ids[0] because normally there is only one line. This is ok for me if it has a comment saying that.

Otherwise LGTM, thanks!
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.

References

lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools
From: Vincent Renaville@camptocamp, 2014-01-16