openerp-community-reviewer team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Hello, 

Thanks for the MP.

Some doc string on _min_max_date_planned would be welcome. 
Also Manifest description is quite laconic you should put commit message inside :)

line 123: You forgot a print statement.
line 130: if name.startswith('min'):
Is there a reason I missed to not check field full name?

Else looks good to me.

Regards

Nicolas
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_stock_global_delivery_lead_time-afe/+merge/197205
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.