openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/contract-management/7.0-block-send-email-lep into lp:contract-management

To: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Fri, 31 Jan 2014 14:34:14 -0000
In-reply-to: <20140108115726.30294.47631.launchpad@ackee.canonical.com>
Reply-to: mp+200812@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

l50ff it seems to me that it is dangerous to return a new action with the current context. I encountered subtle bugs because the active_ids, active_model etc are propagated to the new action when they shouldn't. I think it should just be a new dict.
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-block-send-email-lep/+merge/200812
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.

References

[Merge] lp:~camptocamp/contract-management/7.0-block-send-email-lep into lp:contract-management
From: Leonardo Pistone @ camptocamp, 2014-01-08