openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: "Ronald Portier \(Therp\)" <ronald@xxxxxxxx>
Date: Mon, 03 Feb 2014 21:54:21 -0000
In-reply-to: <20140203165231.4271.66445.launchpad@ackee.canonical.com>
Reply-to: mp+204535@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

I doubt wether this change is really a good idea.

When running python from a virtualenv, in many cases this relies on a virtualenv specific python command to be the first in the path. When using python2, suddenly the whole virtualenv will be ignored and the script will revert to using the system python.

Therefore the change will break most virtualenv installations, which I think will be much more common than Arch Linux installs.

Or do I overlook something?

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394/+merge/204535
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils.

References

[Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils
From: Sandy Carter (http://www.savoirfairelinux.com), 2014-02-03