openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Yann,

looks like this patch disables all variable substitution:

    >>> '%(name)s' % {'name': 'bla'}
    'bla'
    >>> '%(name)s'.replace('%', '%%') % {'name': 'bla'}
    '%(name)s'

Not sure about the validity of this bug. You could view it as a usability issue that the templates need to be configured to contain the double % where a literal % needs to be displayed. Having this 'fixed' on the technical level would misform existing templates that already contain the double %. At this time in the 6.1 lifecycle, I would much rather simply have an additional comment on the action rule view that hints at the need for the double % to display a literal %. So would you please consider changing the view instead of the code?


-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape/+merge/204708
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.