openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules.

Commit message:
[FIX] onchange_shop_id should call super to initialize all the fields properly

Requested reviews:
  Account Core Editors (account-core-editors)
Related bugs:
  Bug #1277125 in openerp-fiscal-rules: "account_fiscal_position_rule_sale: default analytic account and pricelist not copied from shop"
  https://bugs.launchpad.net/openerp-fiscal-rules/+bug/1277125

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125/+merge/205190

Fixes lp:1277125
-- 
https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125/+merge/205190
Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules.

=== modified file 'account_fiscal_position_rule_sale/sale.py'
--- account_fiscal_position_rule_sale/sale.py	2013-12-16 15:22:28 +0000
+++ account_fiscal_position_rule_sale/sale.py	2014-02-06 15:24:08 +0000
@@ -89,7 +89,8 @@
         if not context:
             context = {}
 
-        result = {'value': {}}
+        result = super(sale_order, self).onchange_shop_id(
+            cr, uid, ids, shop_id, context=context)
         if not shop_id or not partner_id:
             return result