openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Hi, Daniel,

Thanks for the patch! Very appreciated.

There are some things IMHO to fix:

- Why that strange import (from openerp.osv.orm import browse_record, browse_null)?
- Indentation in the 'for' block seems bigger of the usual.
- Use PEP8. Renaming for example 'account_analytic_line_obj' variable to something shorter like anal_line_obj will help.
- You don't need second for loop. You can do:
        anal_line_obj.write(cr, uid, todo_ids, {'invoice_id': new_invoice_id}, context=context)
- As on my example, put always context as keyword argument.

Regards.
-- 
https://code.launchpad.net/~oerp.ca/account-invoicing/account_invoice_merge/+merge/204373
Your team Account Core Editors is subscribed to branch lp:account-invoicing.