openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

> Sorry, only checked account_invoice_reorder_lines
> 
> purchase_order_reorder_lines/__init__.py:22:1: F401 'purchase' imported but
> unused

mandated by OpenERP though

> purchase_order_reorder_lines/purchase.py:31:9: E123 closing bracket does not
> match indentation of opening bracket's line

The indentation used is allowed by PEP008 (first option of "closing brace/bracket/parenthesis on multi-line constructs"). In this case it is lined with 'sequence') 


> purchase_order_reorder_lines/purchase.py:83:1: W391 blank line at end of file
> 
> stock_picking_reorder_lines/__init__.py:22:1: F401 'stock' imported but unused

import mandated by OpenERP though

> stock_picking_reorder_lines/stock.py:31:9: E123 closing bracket does not match
> indentation of opening bracket's line

same as for purchase.py

-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe/+merge/197175
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.