openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #03633
Re: [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools
Review: Needs Information
Hello,
Thanks for the review. I will try the it ASAP.
Some remark so:
Some PEP8 here and there.
Can you give us more details about this line:
self.httprequest.url.replace('://', '://logout@')
I'm not sure to understand the use this redirection
Regards
Nicolas
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.
References