openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hello,

Thanks for the contrib on geoaddons

Here are few remarks:

* About license it should be AGPL not GPL
* I agree Copyrights are bad things in OpenSource but can you copy a file and simply replace it? Just asking. Anyway I wouldn't block it for that as I'm pleased and so Nicolas should be that his code is reused and it give some consistency.
* Most of the code is copied from geoengine_geoname_geocoder and I agree with this todo
+#TODO create a base Geocoder module
Wouldn't it be possible to give some more genericity here ?

* Plus some cleaning are needed with deprecated osv.osv and useless check on context
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder/+merge/195296
Your team Geospatial Addons Core Editors is subscribed to branch lp:geospatial-addons.