← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/margin-analysis/7.0-fix_1280221-afe into lp:margin-analysis

 

Review: Needs Information code review

LGTM, but I wonder if there is any possibility to test the infinite recursion itself, because for now, if we have a future regression, test will enter also in an infinite loop.

Don't you think it's better to propose a patch for _bom_explode that avoid infinite recursion? Or is it a specific problem of this module?

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix_1280221-afe/+merge/206486
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.


References